Black Goo Patch #3633
Black Goo Patch #3633
Conversation
realforest2001
added
Logging
| @@ -7,6 +7,10 @@ | |||
|
|
|||
| // This proc has some procs that should be extracted from it. I believe we can develop some helper procs from it - Rockdtben | |||
| /mob/proc/contract_disease(datum/disease/virus, skip_this = 0, force_species_check=1, spread_type = -5) | |||
| if(istype(virus, /datum/disease/black_goo) && (SSticker.mode && !MODE_HAS_TOGGLEABLE_FLAG(MODE_ALLOW_ZOMBIES))) | |||
There was a problem hiding this comment.
Forest seriously I swear.... OOP exists for a reason. At least do it 2018 style and define a handler proc on the disease, don't strap istypes based chunks in the middle of stuff like it's 2012
There was a problem hiding this comment.
if(virus.can_infect(src))
or something i don't know
There was a problem hiding this comment.
But where's the fun in that. If I did everything perfectly first time around you wouldn't have so much fun reviewing it! :HAH:
There was a problem hiding this comment.
Will do this when/if I have time tomorrow
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cm13-github
added
the
Merge Conflict
cm13-github
removed
the
Merge Conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
realforest2001
removed
the
Testmerge Candidate
realforest2001
added
the
Test Merge Only
realforest2001
added
Stale Exempt
About the pull request
Patches Black Goo so there's no more random/accidental infections.
Explain why it's good for the game
APPARENTLY we're randomly having zombies pop up
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
admin: Added a flag that determines if zombies can spread or not. Unauthorised spread will create a big admin message.
/:cl: